Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4F30A1074E for ; Tue, 17 Sep 2013 01:14:25 +0000 (UTC) Received: (qmail 78878 invoked by uid 500); 17 Sep 2013 01:14:24 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 78820 invoked by uid 500); 17 Sep 2013 01:14:24 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 78806 invoked by uid 99); 17 Sep 2013 01:14:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Sep 2013 01:14:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 817F31D3303; Tue, 17 Sep 2013 01:14:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3222485074663172109==" MIME-Version: 1.0 Subject: Re: Review Request 14155: HIVE-5297 Hive does not honor type for partition columns From: "Vikram Dixit Kumaraswamy" To: "Ashutosh Chauhan" Cc: "Vikram Dixit Kumaraswamy" , "hive" , "Sergey Shelukhin" Date: Tue, 17 Sep 2013 01:14:21 -0000 Message-ID: <20130917011421.31242.86707@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vikram Dixit Kumaraswamy" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/14155/ X-Sender: "Vikram Dixit Kumaraswamy" References: <20130916210503.31250.30951@reviews.apache.org> In-Reply-To: <20130916210503.31250.30951@reviews.apache.org> Reply-To: "Vikram Dixit Kumaraswamy" --===============3222485074663172109== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14155/ ----------------------------------------------------------- (Updated Sept. 17, 2013, 1:14 a.m.) Review request for hive and Ashutosh Chauhan. Changes ------- Addressed Sergey's comments. Bugs: HIVE-5297 https://issues.apache.org/jira/browse/HIVE-5297 Repository: hive-git Description ------- Hive does not consider the type of the partition column while writing partitions. Consider for example the query: create table tab1 (id1 int, id2 string) PARTITIONED BY(month string,day int) row format delimited fields terminated by ','; alter table tab1 add partition (month='June', day='second'); Hive accepts this query. However if you try to select from this table and insert into another expecting schema match, it will insert nulls instead. Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1af68a6 ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 393ef57 ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 2ece97e ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java a704462 ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java fb79823 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g ca667d4 ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 767f545 ql/src/test/queries/clientnegative/illegal_partition_type.q PRE-CREATION ql/src/test/queries/clientnegative/illegal_partition_type2.q PRE-CREATION ql/src/test/queries/clientpositive/partition_type_check.q PRE-CREATION ql/src/test/results/clientnegative/illegal_partition_type.q.out PRE-CREATION ql/src/test/results/clientnegative/illegal_partition_type2.q.out PRE-CREATION ql/src/test/results/clientpositive/parititon_type_check.q.out PRE-CREATION ql/src/test/results/clientpositive/partition_type_check.q.out PRE-CREATION Diff: https://reviews.apache.org/r/14155/diff/ Testing ------- Ran all tests. Thanks, Vikram Dixit Kumaraswamy --===============3222485074663172109==--