hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan (JIRA)" <>
Subject [jira] [Commented] (HIVE-5345) Operator::close() leaks Operator::out, holding reference to buffers
Date Mon, 23 Sep 2013 21:07:03 GMT


Ashutosh Chauhan commented on HIVE-5345:

Fix makes sense. Though, I think having output collector reference in operator class is bad
design in first place, since they dont belong there, just a bad implementation. I have looked
this briefly eariler and I think code refactor to eliminate collector from operator is not
lot of work. But thats a matter for another jira.
> Operator::close() leaks Operator::out, holding reference to buffers
> -------------------------------------------------------------------
>                 Key: HIVE-5345
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.13.0
>         Environment: Ubuntu, LXC, jdk6-x86_64
>            Reporter: Gopal V
>            Assignee: Gopal V
>              Labels: memory-leak
>         Attachments: HIVE-5345.01.patch, out-leak.png
> When processing multiple splits on the same operator pipeline, the output collector in
Operator has a held reference, which causes issues.
> Operator::close() does not de-reference the OutputCollector object Operator::out held
by the object.
> This means that trying to allocate space for a new OutputCollector causes an OOM because
the old one is still reachable.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message