hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-5295) HiveConnection#configureConnection tries to execute statement even after it is closed
Date Tue, 24 Sep 2013 03:18:03 GMT

    [ https://issues.apache.org/jira/browse/HIVE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13775950#comment-13775950
] 

Phabricator commented on HIVE-5295:
-----------------------------------

thejas has commented on the revision "HIVE-5295 [jira] HiveConnection#configureConnection
tries to execute statement even after it is closed".

  Looks good . Just some minor comments about making test more easy to read.

INLINE COMMENTS
  jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java:232 I think you can create a function
to check property value to make the test more easy to read.

  something like - verifyProperty(stmt, "hive.cli.print.header", "true");
  jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java:208 can you add a comment describing
that this test tests setting hiveconf and hive variables using connection string ?

REVISION DETAIL
  https://reviews.facebook.net/D12957

To: JIRA, vaibhavgumashta
Cc: thejas

                
> HiveConnection#configureConnection tries to execute statement even after it is closed
> -------------------------------------------------------------------------------------
>
>                 Key: HIVE-5295
>                 URL: https://issues.apache.org/jira/browse/HIVE-5295
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Vaibhav Gumashta
>            Assignee: Vaibhav Gumashta
>             Fix For: 0.12.0
>
>         Attachments: D12957.1.patch, D12957.2.patch
>
>
> HiveConnection#configureConnection tries to execute statement even after it is closed.
For remote JDBC client, it tries to set the conf var using 'set foo=bar' by calling HiveStatement.execute
for each conf var pair, but closes the statement after the 1st iteration through the conf
var pairs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message