hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-5283) Merge vectorization branch to trunk
Date Sun, 15 Sep 2013 22:52:51 GMT

    [ https://issues.apache.org/jira/browse/HIVE-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767942#comment-13767942
] 

Carl Steinbach commented on HIVE-5283:
--------------------------------------

[~jnp] Thanks for posting the patch on reviewboard. Here's some high-level feedback:

* I think we should avoid committing generated code if at all possible. In addition, the build
should be modified to run vector codegen as part of the ql compile phase.
* This patch adds sixteen new vectorization_*.q tests. It's not clear to me what the difference
is between vectorization_3.q and vectorization_8.q, or between vectorization_10.q and vectorization_7.q,
etc, etc. I think it would take some effort for a maintainer to determine what the testing
strategy is, or if there even is one. I'm also worried that in the future people will add
redundant tests because they don't want to spend the time figuring out what is already covered.
In order to avoid this I think it would be good to augment the filenames with quick descriptions,
and to include comments in each qfile quickly explaining what is being tested.
                
> Merge vectorization branch to trunk
> -----------------------------------
>
>                 Key: HIVE-5283
>                 URL: https://issues.apache.org/jira/browse/HIVE-5283
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Jitendra Nath Pandey
>            Assignee: Jitendra Nath Pandey
>         Attachments: HIVE-5283.1.patch, HIVE-5283.2.patch
>
>
> The purpose of this jira is to upload vectorization patch, run tests etc. The actual
work will continue under HIVE-4160 umbrella jira.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message