hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-5278) Move some string UDFs to GenericUDFs, for better varchar support
Date Fri, 13 Sep 2013 08:33:54 GMT

     [ https://issues.apache.org/jira/browse/HIVE-5278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Phabricator updated HIVE-5278:
------------------------------

    Attachment: D12909.1.patch

jdere requested code review of "HIVE-5278 [jira] Move some string UDFs to GenericUDFs, for
better varchar support".

Reviewers: JIRA

HIVE-5278: Move some string UDFs to GenericUDFs, for better varchar support

To better support varchar/char types in string UDFs, select UDFs should be converted to GenericUDFs.
This allows the UDF to return the resulting char/varchar length in the type metadata.

This work is being split off as a separate task from HIVE-4844. The initial UDFs as part of
this work are concat/lower/upper.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D12909

AFFECTED FILES
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFConcat.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLower.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFUpper.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcat.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLower.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUpper.java
  ql/src/test/results/compiler/plan/groupby2.q.xml
  ql/src/test/results/compiler/plan/udf6.q.xml

MANAGE HERALD RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/30879/

To: JIRA, jdere

                
> Move some string UDFs to GenericUDFs, for better varchar support
> ----------------------------------------------------------------
>
>                 Key: HIVE-5278
>                 URL: https://issues.apache.org/jira/browse/HIVE-5278
>             Project: Hive
>          Issue Type: Improvement
>          Components: Types, UDF
>            Reporter: Jason Dere
>            Assignee: Jason Dere
>         Attachments: D12909.1.patch, HIVE-5278.1.patch
>
>
> To better support varchar/char types in string UDFs, select UDFs should be converted
to GenericUDFs. This allows the UDF to return the resulting char/varchar length in the type
metadata.
> This work is being split off as a separate task from HIVE-4844. The initial UDFs as part
of this work are concat/lower/upper.
> NO PRECOMMIT TESTS - dependent on HIVE-4844

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message