hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sushanth Sowmyan (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-5236) Change HCatalog spacing from 4 spaces to 2
Date Fri, 06 Sep 2013 08:47:52 GMT

     [ https://issues.apache.org/jira/browse/HIVE-5236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sushanth Sowmyan updated HIVE-5236:
-----------------------------------

    Attachment: HIVE-5236.patch

Attaching patch. After you apply this patch, you can do a git diff -b to see that the only
changes (apart from the one to coding_style.xml) are whitespace changes.
                
> Change HCatalog spacing from 4 spaces to 2
> ------------------------------------------
>
>                 Key: HIVE-5236
>                 URL: https://issues.apache.org/jira/browse/HIVE-5236
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sushanth Sowmyan
>            Assignee: Sushanth Sowmyan
>             Fix For: 0.12.0
>
>         Attachments: HIVE-5236.patch
>
>
> Now that we went around changing hcatalog package to be inside hive with HIVE-4869, one
of the remaining sore points is that hcatalog standardizes on 4 spaces for its indenting style,
and hive standardizes on 2 spaces for its indenting style. This causes headaches for those
of us who have to edit parts of both.
> We've thus far not bothered changing them because we didn't want to lose modification
history for hcatalog, but due to the svn mv we had to do, we've already lost that battle.
So, we might as well go ahead and do this.
> I'm also creating this as a separate patch because I don't want to expand the scope of
HIVE-4869 which is complex enough. If we agree to do this, we should do this soon.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message