hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-5196) ThriftCLIService.java uses stderr to print the stack trace, it should use the logger instead.
Date Thu, 26 Sep 2013 01:08:02 GMT

     [ https://issues.apache.org/jira/browse/HIVE-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Phabricator updated HIVE-5196:
------------------------------

    Attachment: D13107.1.patch

vaibhavgumashta requested code review of "HIVE-5196 [jira] ThriftCLIService.java uses stderr
to print the stack trace, it should use the logger instead.".

Reviewers: JIRA

HIVE-5196: ThriftCLIService should use LOG.error instead of stderr to log error description

ThriftCLIService.java uses stderr to print the stack trace, it should use the logger instead.
Using e.printStackTrace is not suitable for production.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D13107

AFFECTED FILES
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java

MANAGE HERALD RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/38265/

To: JIRA, vaibhavgumashta

                
> ThriftCLIService.java uses stderr to print the stack trace, it should use the logger
instead.
> ---------------------------------------------------------------------------------------------
>
>                 Key: HIVE-5196
>                 URL: https://issues.apache.org/jira/browse/HIVE-5196
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.12.0
>            Reporter: Vaibhav Gumashta
>            Assignee: Vaibhav Gumashta
>             Fix For: 0.12.0
>
>         Attachments: D13107.1.patch
>
>
> ThriftCLIService.java uses stderr to print the stack trace, it should use the logger
instead. Using e.printStackTrace is not suitable for production.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message