hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-4763) add support for thrift over http transport in HS2
Date Wed, 11 Sep 2013 04:35:51 GMT

    [ https://issues.apache.org/jira/browse/HIVE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763959#comment-13763959
] 

Phabricator commented on HIVE-4763:
-----------------------------------

cwsteinbach has commented on the revision "HIVE-4763 [jira] add support for thrift over http
transport in HS2".

INLINE COMMENTS
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:722 The values should be "binary"
and "http", not "thrift" and "http".

  Also, I think some people are going to want to run in both modes simultaneously, so why
not support a comma separated list of values?
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:723 For these properties please
use the prefix hive.server2.thrift.http.*
  jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:134 Please fix the formatting in
this method.
  jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:160 Import org.apache.thrift.transport.THttpClient.
  jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:135 Include the expected prefix in
the error message.
  jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:231 static method
  jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:239 ditto
  jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:251 ditto
  jdbc/src/java/org/apache/hive/jdbc/HttpBasicAuthInterceptor.java:1 Missing ASF license header.
  jdbc/src/java/org/apache/hive/jdbc/HttpBasicAuthInterceptor.java:21 Formatting.
  jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java:1119 Both binary and http depend
on top of TCP. This is binary mode.
  jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java:1126 Doesn't this belong down below
in HTTP_URL_PROPERTIES?
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java:234 hiveserver1 http mode?
It looks like this patch only adds support for http in HS2.
  service/src/java/org/apache/hive/service/cli/thrift/HttpServlet.java:1 Missing ASF header.
  service/src/java/org/apache/hive/service/cli/thrift/HttpServlet.java:25 Multiple formatting
issues.
  service/src/java/org/apache/hive/service/cli/thrift/HttpServlet.java:45 Import the class,
or do a static import for the method.
  service/src/java/org/apache/hive/service/cli/thrift/HttpServlet.java:15 Usually the names
of child classes are more specific/specialized than the parent class. Please change the name
to something that makes more sense.
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java:408 Please make
ThriftCLIService abstract and move this logic into two child classes: ThriftBinaryCLIService
and ThriftHttpCLIService.
  service/src/test/org/apache/hive/service/server/TestHS2HttpInvalidConf.java:1 Formatting
  service/src/test/org/apache/hive/service/server/TestHiveServer2Http.java:1 Formatting.
  service/src/test/org/apache/hive/service/server/TestHiveServer2Http.java:99 Please provide
a more descriptive name than "test".

REVISION DETAIL
  https://reviews.facebook.net/D12855

To: JIRA, vaibhavgumashta
Cc: thejas, cwsteinbach

                
> add support for thrift over http transport in HS2
> -------------------------------------------------
>
>                 Key: HIVE-4763
>                 URL: https://issues.apache.org/jira/browse/HIVE-4763
>             Project: Hive
>          Issue Type: Sub-task
>          Components: HiveServer2
>            Reporter: Thejas M Nair
>            Assignee: Vaibhav Gumashta
>             Fix For: 0.12.0
>
>         Attachments: HIVE-4763.1.patch, HIVE-4763.2.patch, HIVE-4763.D12855.1.patch
>
>
> Subtask for adding support for http transport mode for thrift api in hive server2.
> Support for the different authentication modes will be part of another subtask.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message