hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward Capriolo (JIRA)" <>
Subject [jira] [Commented] (HIVE-4732) Reduce or eliminate the expensive Schema equals() check for AvroSerde
Date Wed, 18 Sep 2013 01:29:51 GMT


Edward Capriolo commented on HIVE-4732:

I do disagree, because it is not complex to generate a GUID that will never collide.

An implementation would likely replace 1 line of code with between 2 to 4. It is not a complex
task and there are probably hundreds of references on how to do this on the internet.

import java.rmi.server.UID;

public class UniqueId {

  * Build and display some UID objects.
  public static void main (String... arguments) {
    for (int idx=0; idx<10; ++idx){
      UID userId = new UID();
      System.out.println("User Id: " + userId);

Would you rather have: 
1) a parachute that very very rarely does not work
2) a parachute that always works
> Reduce or eliminate the expensive Schema equals() check for AvroSerde
> ---------------------------------------------------------------------
>                 Key: HIVE-4732
>                 URL:
>             Project: Hive
>          Issue Type: Improvement
>          Components: Serializers/Deserializers
>            Reporter: Mark Wagner
>            Assignee: Mohammad Kamrul Islam
>         Attachments: HIVE-4732.1.patch, HIVE-4732.4.patch, HIVE-4732.5.patch, HIVE-4732.v1.patch,
> The AvroSerde spends a significant amount of time checking schema equality. Changing
to compare hashcodes (which can be computed once then reused) will improve performance.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message