hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-4617) ExecuteStatementAsync call to run a query in non-blocking mode
Date Tue, 03 Sep 2013 07:32:54 GMT

    [ https://issues.apache.org/jira/browse/HIVE-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756418#comment-13756418
] 

Phabricator commented on HIVE-4617:
-----------------------------------

cwsteinbach has commented on the revision "HIVE-4617 [jira] ExecuteStatementAsync call to
run a query in non-blocking mode".

INLINE COMMENTS
  conf/hive-default.xml.template:1857 This value doesn't match the one listed in HiveConf
("500").
  conf/hive-default.xml.template:1864 Do you think people will actually want to set this value
to a fraction of second? If not I recommend changing the units to seconds.
  service/if/TCLIService.thrift:42 Please add a blank line between lines 41 and 42.
  service/src/java/org/apache/hive/service/cli/OperationState.java:68 I think WAITING->FINISHED
and WAITING->CLOSED probably aren't valid transitions, but I'm not sure. What do you think?
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java:59 s/VG/TODO/
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java:81 10,000ms should
not be hardcoded. Please reference 'timeout' instead.
  service/src/java/org/apache/hive/service/cli/OperationState.java:75 If RUNNING->WAITING
is not a valid transition (which makes sense to me), then maybe we should use the adjective
PENDING instead of WAITING.

  "There are only two hard things in Computer Science: cache invalidation and naming things."
  -- Phil Karlton

REVISION DETAIL
  https://reviews.facebook.net/D12507

To: JIRA, vaibhavgumashta
Cc: cwsteinbach

                
> ExecuteStatementAsync call to run a query in non-blocking mode
> --------------------------------------------------------------
>
>                 Key: HIVE-4617
>                 URL: https://issues.apache.org/jira/browse/HIVE-4617
>             Project: Hive
>          Issue Type: Improvement
>          Components: HiveServer2
>    Affects Versions: 0.12.0
>            Reporter: Jaideep Dhok
>            Assignee: Vaibhav Gumashta
>         Attachments: HIVE-4617.D12417.1.patch, HIVE-4617.D12417.2.patch, HIVE-4617.D12417.3.patch,
HIVE-4617.D12417.4.patch, HIVE-4617.D12417.5.patch, HIVE-4617.D12417.6.patch, HIVE-4617.D12507.1.patch,
HIVE-4617.D12507.2.patch, HIVE-4617.D12507Test.1.patch
>
>
> Provide a way to run a queries asynchronously. Current executeStatement call blocks until
the query run is complete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message