hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gunther Hagleitner" <ghagleit...@hortonworks.com>
Subject Re: Review Request 14349: HIVE-5271: Convert join op to a map join op in the planning phase
Date Thu, 26 Sep 2013 18:14:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14349/#review26413
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/parse/ConvertJoinMapJoin.java
<https://reviews.apache.org/r/14349/#comment51602>

    is this the right package? shouldn't it be in optimizer?



ql/src/java/org/apache/hadoop/hive/ql/parse/ConvertJoinMapJoin.java
<https://reviews.apache.org/r/14349/#comment51603>

    i think we can do w/o the default.



ql/src/java/org/apache/hadoop/hive/ql/parse/ConvertJoinMapJoin.java
<https://reviews.apache.org/r/14349/#comment51598>

    this should probably just bail instead of throwing exception.



ql/src/java/org/apache/hadoop/hive/ql/parse/ConvertJoinMapJoin.java
<https://reviews.apache.org/r/14349/#comment51600>

    some more comments on what the tree needs to look like would be helpful


- Gunther Hagleitner


On Sept. 26, 2013, 5:51 p.m., Vikram Dixit Kumaraswamy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14349/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2013, 5:51 p.m.)
> 
> 
> Review request for hive and Gunther Hagleitner.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
>  Convert join op to a map join op in the planning phase.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 31ca07a 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ConvertJoinMapJoin.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 7e51310 
> 
> Diff: https://reviews.apache.org/r/14349/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vikram Dixit Kumaraswamy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message