hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <c...@cloudera.com>
Subject Re: Review Request 14250: HIVE-4957: Restrict number of bit vectors, to prevent out of Java heap memory
Date Fri, 20 Sep 2013 20:38:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14250/#review26304
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java
<https://reviews.apache.org/r/14250/#comment51390>

    Please use a static variable instead of repeating "1024":
    
    private static final MAX_NUM_BIT_VECTORS = 1024;



ql/src/test/queries/clientnegative/compute_stats_long.q
<https://reviews.apache.org/r/14250/#comment51391>

    Why should it raise an error?


- Carl Steinbach


On Sept. 20, 2013, 8:02 p.m., Shreepadma Venugopalan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14250/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2013, 8:02 p.m.)
> 
> 
> Review request for hive and Brock Noland.
> 
> 
> Bugs: HIVE-4957
>     https://issues.apache.org/jira/browse/HIVE-4957
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Restricts the number of bit vectors used by Flajolet-Martin distinct value estimator
to 1024.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java 63110bb

>   ql/src/test/queries/clientnegative/compute_stats_long.q PRE-CREATION 
>   ql/src/test/results/clientnegative/compute_stats_long.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14250/diff/
> 
> 
> Testing
> -------
> 
> Adds a new negative test case.
> 
> 
> Thanks,
> 
> Shreepadma Venugopalan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message