hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Hanson" <eh...@microsoft.com>
Subject Re: Review Request 14113: support standard UDFs and generic UDFs in vectorized mode with an adaptor
Date Sat, 14 Sep 2013 01:23:31 GMT


> On Sept. 13, 2013, 6 a.m., Brock Noland wrote:
> > Hey, 
> > 
> > First off let me say you've don't a massive job in the vectorization branch! Nice
work! I obviously don't have a enough context to do a real review. However, I just noticed
you guys wanted to merge this branch soon so I took a peak at this issue. There is a large
amount of trailing whitespace in this patch. Can you remove that? It shows up in red on RB.

Yes, I've removed it. Thanks for looking at the code, Brock.


- Eric


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14113/#review26071
-----------------------------------------------------------


On Sept. 12, 2013, 11:57 p.m., Eric Hanson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14113/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2013, 11:57 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-4961
>     https://issues.apache.org/jira/browse/HIVE-4961
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Added support standard UDFs and generic UDFs in vectorized mode with an adaptor. Includes
unit tests.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 3d8ade6

>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFAdaptor.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFArgDesc.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 5b467bb 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 048824a 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java 52fe47b 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/GenericUDFIsNull.java
PRE-CREATION 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/LongUDF.java PRE-CREATION

>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestUDF.java PRE-CREATION

>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorUDFAdaptor.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14113/diff/
> 
> 
> Testing
> -------
> 
> Also did extensive ad-hoc end-to end tests with a variety of UDFs.
> 
> 
> Thanks,
> 
> Eric Hanson
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message