Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Thu, 22 Aug 2013 21:51:52 +0000 (UTC)
From: "Phabricator (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: <JIRA.12665001.1377159811033.19325.1377208312719@arcas>
In-Reply-To: <JIRA.12665001.1377159811033@arcas>
References: <JIRA.12665001.1377159811033@arcas>
Subject: [jira] [Commented] (HIVE-5137) A Hive SQL query should not return a
 ResultSet when the underlying plan does not include a FetchTask
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HIVE-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747924#comment-13747924 ] 

Phabricator commented on HIVE-5137:
-----------------------------------

thejas has commented on the revision "HIVE-5137 [jira] A Hive SQL query should not return a ResultSet when the underlying plan does not include a FetchTaskSQL".

INLINE COMMENTS
  jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java:473 I think writing it to stderr is better. Maybe create a function for this -

        e.printStackTrace();
        fail(e.toString());
  jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java:468 a function for this will make it more readable -
  Something like -
  checkResultsAvailable(String[] setupStmts, String stmt, boolean resultsExpected)
  jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java:267 We need to look at ways to get explain statement giving results as well.

REVISION DETAIL
  https://reviews.facebook.net/D12453

To: JIRA, vaibhavgumashta
Cc: thejas

                
> A Hive SQL query should not return a ResultSet when the underlying plan does not include a FetchTask
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-5137
>                 URL: https://issues.apache.org/jira/browse/HIVE-5137
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2
>    Affects Versions: 0.11.0
>            Reporter: Vaibhav Gumashta
>            Assignee: Vaibhav Gumashta
>         Attachments: HIVE-5137.D12453.1.patch, HIVE-5137.D12453.2.patch, HIVE-5137.D12453.3.patch, HIVE-5137.D12453.4.patch, HIVE-5137.D12453.5.patch
>
>
> Currently, a query like "create table if not exists t2 as select * from t1" sets the hasResultSet to true in SQLOperation and in turn, the query returns a result set. However, as a DDL command, this should ideally not return a result set.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira