hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Jakobus (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-5044) StringUtils
Date Fri, 09 Aug 2013 20:30:50 GMT

     [ https://issues.apache.org/jira/browse/HIVE-5044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Benjamin Jakobus updated HIVE-5044:
-----------------------------------

    Assignee: Benjamin Jakobus
    
> StringUtils
> -----------
>
>                 Key: HIVE-5044
>                 URL: https://issues.apache.org/jira/browse/HIVE-5044
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Benjamin Jakobus
>            Assignee: Benjamin Jakobus
>             Fix For: 0.12.0
>
>
> When you see code like this:
> first = true;
> for (int k = 0; k < columnSize; k++) {
> String newColName = i + "VALUE" + k; // any name, it does not matter.
> + newColName = i + "VALUE" + k; // any name, it does not matter.
> if (!first)
> Unknown macro: { - valueColNames = valueColNames + ","; - valueColTypes = valueColTypes
+ ","; + valueColNames.append(","); + valueColTypes.append(","); }
> valueColNames = valueColNames + newColName;
> valueColTypes = valueColTypes + valueCols.get(k).getTypeString();
> + valueColNames.append(newColName);
> + valueColTypes.append(valueCols.get(k).getTypeString());
> first = false;
> Can you replace it with StringUtil.join()
> I have seen this about 4 places in hive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message