hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <>
Subject [jira] [Commented] (HIVE-5029) direct SQL perf optimization cannot be tested well
Date Wed, 28 Aug 2013 17:12:52 GMT


Phabricator commented on HIVE-5029:

ashutoshc has requested changes to the revision "HIVE-5029 [jira] direct SQL perf optimization
cannot be tested well".

  Couple of comments.

  metastore/src/java/org/apache/hadoop/hive/metastore/ Why is this
change required?
  metastore/src/java/org/apache/hadoop/hive/metastore/ Can you
place this class in metastore/src/test instead of metastore/src/java ?




To: JIRA, ashutoshc, sershe

> direct SQL perf optimization cannot be tested well
> --------------------------------------------------
>                 Key: HIVE-5029
>                 URL:
>             Project: Hive
>          Issue Type: Test
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Critical
>         Attachments: HIVE-5029.D12483.1.patch, HIVE-5029.patch, HIVE-5029.patch
> HIVE-4051 introduced perf optimization that involves getting partitions directly via
SQL in metastore. Given that SQL queries might not work on all datastores (and will not work
on non-SQL ones), JDO fallback is in place.
> Given that perf improvement is very large for short queries, it's on by default.
> However, there's a problem with tests with regard to that. If SQL code is broken, tests
may fall back to JDO and pass. If JDO code is broken, SQL might allow tests to pass.
> We are going to disable SQL by default before the testing problem is resolved.
> There are several possible solultions:
> 1) Separate build for this setting. Seems like an overkill...
> 2) Enable by default; disable by default in tests, create a clone of TestCliDriver with
a subset of queries that will exercise the SQL path.
> 3) Have some sort of test hook inside metastore that will run both ORM and SQL and compare.
> 3') Or make a subclass of ObjectStore that will do that. ObjectStore is already pluggable.
> 4) Write unit tests for one of the modes (JDO, as non-default?) and declare that they
are sufficient; disable fallback in tests.
> 3' seems like the easiest. For now we will disable SQL by default.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message