hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gunther Hagleitner (JIRA)" <>
Subject [jira] [Commented] (HIVE-5006) Re-factor HiveServer2 JDBC PreparedStatement to avoid duplicate code
Date Thu, 08 Aug 2013 09:12:48 GMT


Gunther Hagleitner commented on HIVE-5006:

Lots of red in the code + green in the tests. Very nice. LGTM +1. [~prasadm] can you take
a look at [~thejas]'s comments? Seems like they are minor - will commit after you make an
> Re-factor HiveServer2 JDBC PreparedStatement to avoid duplicate code
> --------------------------------------------------------------------
>                 Key: HIVE-5006
>                 URL:
>             Project: Hive
>          Issue Type: Improvement
>          Components: HiveServer2, JDBC
>    Affects Versions: 0.11.0
>            Reporter: Prasad Mujumdar
>            Assignee: Prasad Mujumdar
>             Fix For: 0.12.0
>         Attachments: HIVE-5006.1.patch
> The JDBC PreparedStatement interface extends Statement interface. The Hive JDBC driver
implementations of HivePreparedStatement interface is disjoint from the HiveStatement implementation.
As a result there's some duplicate code in these two classes for executing query. Also patches
like implicit close on re-execute etc. are not there for PreparedStatement.
> The HivePreparedStatement should extend the HiveStatement.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message