hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <>
Subject [jira] [Commented] (HIVE-4914) filtering via partition name should be done inside metastore server (implementation)
Date Fri, 30 Aug 2013 21:28:52 GMT


Phabricator commented on HIVE-4914:

sershe has commented on the revision "HIVE-4914 [jira] filtering via partition name should
be done inside metastore server (implementation)".

  metastore/src/java/org/apache/hadoop/hive/metastore/ TreeVisitor
is part of the tree, and this is logically the part of metastoresql... I think it makes sense
to not expose it, it's a private class
  metastore/src/java/org/apache/hadoop/hive/metastore/ that's in separate
patch that is not in yet. will adjust either way when resolving conflict
  metastore/src/java/org/apache/hadoop/hive/metastore/ the old methods
are still there; old versions of hive client, or some other clients, might call them. I will
add this to the comment
  metastore/src/java/org/apache/hadoop/hive/metastore/ this is old JDO
code, it just moved
  metastore/src/java/org/apache/hadoop/hive/metastore/ filed HIVE-5190
  metastore/src/java/org/apache/hadoop/hive/metastore/ I think this should
be separate JIRA to refactor. I can move JDO partition retrieval into separate class, but
ideally it should be a refactoring patch without code changes, otherwise it's hard to understand
what broke if something does
  metastore/src/java/org/apache/hadoop/hive/metastore/parser/ This
class needs access to internals, and both are very small by themselves...




To: JIRA, ashutoshc, sershe

> filtering via partition name should be done inside metastore server (implementation)
> ------------------------------------------------------------------------------------
>                 Key: HIVE-4914
>                 URL:
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-4914.01.patch, HIVE-4914.D12561.1.patch, HIVE-4914-only-no-gen.patch,
HIVE-4914-only.patch, HIVE-4914.patch, HIVE-4914.patch, HIVE-4914.patch
> Currently, if the filter pushdown is impossible (which is most cases), the client gets
all partition names from metastore, filters them, and asks for partitions by names for the
filtered set.
> Metastore server code should do that instead; it should check if pushdown is possible
and do it if so; otherwise it should do name-based filtering.
> Saves the roundtrip with all partition names from the server to client, and also removes
the need to have pushdown viability checking on both sides.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message