hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables
Date Sat, 24 Aug 2013 20:25:21 GMT


> On Aug. 22, 2013, 8:09 a.m., Thejas Nair wrote:
> > beeline/src/java/org/apache/hive/beeline/BeeLine.java, line 509
> > <https://reviews.apache.org/r/11334/diff/3/?file=342835#file342835line509>
> >
> >     I think having this in a function (parseHiveVariables(args) ?) would help in
keeping the hive specific code separate
> >

When I attempted doing this, I found that parsing hive variables is an integral part of the
for loop processing the commadline options. Separating it to another loop seems making the
two loops more complicated because one loop will need to skip those args that are processed
in the other. Thus, I kept this code unchanged. Let me know if you're okay with it.


- Xuefu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11334/#review25408
-----------------------------------------------------------


On Aug. 24, 2013, 8:19 p.m., Xuefu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11334/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 8:19 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-4568
>     https://issues.apache.org/jira/browse/HIVE-4568
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> 1. Added command variable substition
> 2. Added test case
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 4c6eb9b 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.properties b6650cf 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 61bdeee 
>   beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java c70003d 
>   beeline/src/test/org/apache/hive/beeline/src/test/TestBeeLineWithArgs.java 030f6b0

> 
> Diff: https://reviews.apache.org/r/11334/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Xuefu Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message