Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Tue, 30 Jul 2013 21:19:48 +0000 (UTC)
From: "Yin Huai (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: <JIRA.12660768.1375215518098.139777.1375219188567@arcas>
In-Reply-To: <JIRA.12660768.1375215518098@arcas>
References: <JIRA.12660768.1375215518098@arcas>
Subject: [jira] [Updated] (HIVE-4960) lastAlias in CommonJoinOperator is not
 used
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HIVE-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yin Huai updated HIVE-4960:
---------------------------

    Status: Patch Available  (was: Open)
    
> lastAlias in CommonJoinOperator is not used
> -------------------------------------------
>
>                 Key: HIVE-4960
>                 URL: https://issues.apache.org/jira/browse/HIVE-4960
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Yin Huai
>            Assignee: Yin Huai
>            Priority: Minor
>         Attachments: HIVE-4960.D11895.1.patch
>
>
> In CommonJoinOperator, there is object called lastAlias. The initial value of this object is 'null'. After tracing the usage of this object, I found that there is no place to change the value of this object. Also, it is only used in processOp in JoinOperator and MapJoinOperator as
> {code}
> if ((lastAlias == null) || (!lastAlias.equals(alias))) {
>   nextSz = joinEmitInterval;
> }
> {\code}
> Since lastAlias will always be null, we will assign joinEmitInterval to nextSz every time we get a row. Later in processOp, we have 
> {code}
> nextSz = getNextSize(nextSz);
> {\code}
> Because we reset the value of nextSz to joinEmitInterval every time we get a row, seems that getNextSize will not be used as expected.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira