Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EA071F656 for ; Wed, 17 Jul 2013 04:09:00 +0000 (UTC) Received: (qmail 16427 invoked by uid 500); 17 Jul 2013 04:08:54 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 16382 invoked by uid 500); 17 Jul 2013 04:08:53 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 16283 invoked by uid 500); 17 Jul 2013 04:08:51 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 16167 invoked by uid 99); 17 Jul 2013 04:08:48 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Jul 2013 04:08:48 +0000 Date: Wed, 17 Jul 2013 04:08:48 +0000 (UTC) From: "Hudson (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-4845) Correctness issue with MapJoins using the null safe operator MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710664#comment-13710664 ] Hudson commented on HIVE-4845: ------------------------------ SUCCESS: Integrated in Hive-trunk-hadoop1-ptest #87 (See [https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/87/]) HIVE-4845 : Correctness issue with MapJoins using the null safe operator (Brock Noland via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1503818) * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinDoubleKeys.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinObjectKey.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/persistence * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/persistence/TestMapJoinKeys.java * /hive/trunk/ql/src/test/results/clientpositive/join_nullsafe.q.out > Correctness issue with MapJoins using the null safe operator > ------------------------------------------------------------ > > Key: HIVE-4845 > URL: https://issues.apache.org/jira/browse/HIVE-4845 > Project: Hive > Issue Type: Bug > Reporter: Brock Noland > Assignee: Brock Noland > Priority: Critical > Fix For: 0.12.0 > > Attachments: HIVE-4845.patch, HIVE-4845.patch, HIVE-4845.patch > > > I found a correctness issue while working on HIVE-4838. The following query from join_nullsafe.q gives different results depending on if it's executed map-side or reduce-side: > {noformat} > SELECT /*+ MAPJOIN(a) */ * FROM smb_input1 a JOIN smb_input1 b ON a.key <=> b.key AND a.value <=> b.value ORDER BY a.key, a.value, b.key, b.value; > {noformat} > For that query, on the map side, rows which should be joined are not. For example, the reduce side outputs this row: > {noformat} > a.key a.value b.key b.value > 148 NULL 148 NULL > {noformat} > which makes sense since a.key is equal to b.key and a.value is equal to b.value but the current map-side code omits this row. The reason is that MapJoinDoubleKey is used for the map-side join which doesn't properly compare null values. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira