Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Received-SPF: pass (athena.apache.org: domain of edlinuxguru@gmail.com
 designates 209.85.212.178 as permitted sender)
MIME-Version: 1.0
Date: Sun, 21 Jul 2013 15:27:07 -0400
Message-ID: 
 <CAENxBwyGiYRsqQwC7whhE0+PjOjyRJO1nEyNR+n6P5-no0YDdQ@mail.gmail.com>
Subject: Great progress with the hive pre-commit hive build farm
From: Edward Capriolo <edlinuxguru@gmail.com>
To: "<hive-dev@hadoop.apache.org>" <hive-dev@hadoop.apache.org>,
	"hive-user@hadoop.apache.org" <hive-user@hadoop.apache.org>
Content-Type: multipart/alternative; boundary=047d7b5d3528adabf504e20a8b77

--047d7b5d3528adabf504e20a8b77
Content-Type: text/plain; charset=ISO-8859-1

We now have a system automatically building and testing patches. Thanks
much to Brock and Cloudera for driving this through.

https://builds.apache.org/user/brock/my-views/view/hive/job/PreCommit-HIVE-Build/

I can already see by the 30 day summary that this has greatly accelerate
the test-and-commit process. We are getting one or sometimes two reviews
and votes on issues! We are also creating more issues to now, but that is a
happy problem :)

There is a big swath of things on the backlog that we and the patch tester
will have to chew through. If you have a feature you would like reviewed
please read:

1) contributing rules
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
and
https://cwiki.apache.org/confluence/display/Hive/Hive+PreCommit+Patch+Testing
and

We are not yet running this automatically. You should run checkstyle before
you send a patch. You can also setup your IDE to use apache conventions and
your IDE will do the cleanup for you.

2) As Namit pointed out on the dev list in an earlier email, we are a thin
on java-doc. I do believe that good code is self documenting, but the 'why'
gets lost sometimes. I think Gunther did a great job here to document the
fact that ':' is not an acceptable character as an example.

https://issues.apache.org/jira/browse/HIVE-4865

As I mentioned, we have a backlog now and it will take some time to chop
that down, but
now might be a good time to rebase your patch and clean it up a bit.

Edward

--047d7b5d3528adabf504e20a8b77--