Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C19910704 for ; Tue, 23 Jul 2013 21:54:35 +0000 (UTC) Received: (qmail 81075 invoked by uid 500); 23 Jul 2013 21:54:35 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 81021 invoked by uid 500); 23 Jul 2013 21:54:35 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 81011 invoked by uid 99); 23 Jul 2013 21:54:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jul 2013 21:54:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A2D941D00CF; Tue, 23 Jul 2013 21:54:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1711112723155472560==" MIME-Version: 1.0 Subject: Re: Review Request 12824: [HIVE-4911] Enable QOP configuration for Hive Server 2 thrift transport From: "Thejas Nair" To: "hive" , "Thejas Nair" , "Arup Malakar" Date: Tue, 23 Jul 2013 21:54:32 -0000 Message-ID: <20130723215432.4985.25985@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Thejas Nair" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/12824/ X-Sender: "Thejas Nair" References: <20130722205604.4976.85399@reviews.apache.org> In-Reply-To: <20130722205604.4976.85399@reviews.apache.org> Reply-To: "Thejas Nair" --===============1711112723155472560== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12824/#review23722 ----------------------------------------------------------- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java should we just call this hive.server2.thrift.sasl.qop ? That seems more self describing. - Thejas Nair On July 22, 2013, 8:56 p.m., Arup Malakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12824/ > ----------------------------------------------------------- > > (Updated July 22, 2013, 8:56 p.m.) > > > Review request for hive. > > > Bugs: HIVE-4911 > https://issues.apache.org/jira/browse/HIVE-4911 > > > Repository: hive-git > > > Description > ------- > > The QoP for hive server 2 should be configurable to enable encryption. A new configuration should be exposed "hive.server2.thrift.rpc.protection". This would give greater control configuring hive server 2 service. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 11c31216495d0c4e454f2627af5c93a9f270b1fe > data/conf/hive-site.xml 4e6ff16135833da1a4df12a12a6fe59ad4f870ba > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 00f43511b478c687b7811fc8ad66af2b507a3626 > service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java 1809e1b26ceee5de14a354a0e499aa8c0ab793bf > service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java 379dafb8377aed55e74f0ae18407996bb9e1216f > service/src/java/org/apache/hive/service/auth/SaslQOP.java PRE-CREATION > shims/src/common-secure/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 777226f8da0af2235d4294cd6a676fa8192c89e4 > shims/src/common/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java 9b0ec0a75563b41339e6fc747556440fdf83e31e > > Diff: https://reviews.apache.org/r/12824/diff/ > > > Testing > ------- > > > Thanks, > > Arup Malakar > > --===============1711112723155472560==--