Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9CEDE1056B for ; Mon, 22 Jul 2013 22:51:31 +0000 (UTC) Received: (qmail 89541 invoked by uid 500); 22 Jul 2013 22:51:31 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 89498 invoked by uid 500); 22 Jul 2013 22:51:31 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 89486 invoked by uid 99); 22 Jul 2013 22:51:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Jul 2013 22:51:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 82A7D1CFDBC; Mon, 22 Jul 2013 22:51:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4115411434978799834==" MIME-Version: 1.0 Subject: Re: Review Request 12826: HIVE-4913: Put deterministic ordering in the top-K ngrams output of UDF context_ngrams() From: "Xuefu Zhang" To: "Xuefu Zhang" , "hive" Date: Mon, 22 Jul 2013 22:51:30 -0000 Message-ID: <20130722225130.4976.82796@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Xuefu Zhang" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/12826/ X-Sender: "Xuefu Zhang" References: <20130722225118.4985.72778@reviews.apache.org> In-Reply-To: <20130722225118.4985.72778@reviews.apache.org> Reply-To: "Xuefu Zhang" --===============4115411434978799834== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12826/ ----------------------------------------------------------- (Updated July 22, 2013, 10:51 p.m.) Review request for hive. Bugs: HIVE-4913 https://issues.apache.org/jira/browse/HIVE-4913 Repository: hive-git Description ------- Patch add tie breaker when two entries have the same ngram. Diffs ----- metastore/src/model/package.jdo a84d2bf ql/src/java/org/apache/hadoop/hive/ql/udf/generic/NGramEstimator.java 0ef8fca ql/src/test/results/clientpositive/udaf_context_ngrams.q.out de2d395 Diff: https://reviews.apache.org/r/12826/diff/ Testing ------- Test udaf_context_ngrams.q fails when running on JDK7. With the patch, the test passes. Thanks, Xuefu Zhang --===============4115411434978799834==--