Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 34DE710C40 for ; Mon, 22 Jul 2013 01:20:15 +0000 (UTC) Received: (qmail 89326 invoked by uid 500); 22 Jul 2013 01:20:14 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 89278 invoked by uid 500); 22 Jul 2013 01:20:14 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 89267 invoked by uid 99); 22 Jul 2013 01:20:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Jul 2013 01:20:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EA8351CFB14; Mon, 22 Jul 2013 01:20:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2807999677619308725==" MIME-Version: 1.0 Subject: Re: Review Request 9276: Add support for pulling HBase columns with prefixes From: "Swarnim Kulkarni" To: "Swarnim Kulkarni" , "Mark Grover" , "hive" , "Brock Noland" Date: Mon, 22 Jul 2013 01:20:13 -0000 Message-ID: <20130722012013.4976.89413@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Swarnim Kulkarni" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/9276/ X-Sender: "Swarnim Kulkarni" References: <20130209215623.13217.69370@reviews.apache.org> In-Reply-To: <20130209215623.13217.69370@reviews.apache.org> Reply-To: "Swarnim Kulkarni" --===============2807999677619308725== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9276/ ----------------------------------------------------------- (Updated July 22, 2013, 1:20 a.m.) Review request for hive. Changes ------- Updated diff with proposed changes. Bugs: HIVE-3725 https://issues.apache.org/jira/browse/HIVE-3725 Repository: hive-git Description ------- Added support for pulling hbase columns just by providing prefixes and a wildcard. So a query now could look something like this: CREATE EXTERNAL TABLE hive_hbase_test ROW FORMAT SERDE 'org.apache.hadoop.hive.hbase.HBaseSerDe' STORED BY 'org.apache.hadoop.hive.hbase.HBaseStorageHandler' WITH SERDEPROPERTIES ("hbase.columns.mapping" = ":key,fam1:col*") TBLPROPERTIES ("hbase.table.name" = "TEST_HBASE_TABLE"); This would pull in all columns under column family "fam1" which start with "col". This gives a little more flexibility over pull all columns format. Diffs (updated) ----- hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java 65c81bf hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java b550f45 hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java 01938a7 hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseCellMap.java a8ba9d9 hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseRow.java 10a9207 hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestHBaseSerDe.java e821282 Diff: https://reviews.apache.org/r/9276/diff/ Testing ------- Added unit tests to demonstrate the new functionality. Also made sure that all existing unit tests passed. Thanks, Swarnim Kulkarni --===============2807999677619308725==--