Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9BB50109E8 for ; Thu, 18 Jul 2013 23:22:50 +0000 (UTC) Received: (qmail 51633 invoked by uid 500); 18 Jul 2013 23:22:50 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 51585 invoked by uid 500); 18 Jul 2013 23:22:50 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 51576 invoked by uid 99); 18 Jul 2013 23:22:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jul 2013 23:22:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8F0A81CB81B; Thu, 18 Jul 2013 23:22:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5536286401666950126==" MIME-Version: 1.0 Subject: Re: Review Request 12748: HIVE-4883 - TestHadoop20SAuthBridge tests fail sometimes because of race condition From: "Thejas Nair" To: "Thejas Nair" , "hive" Date: Thu, 18 Jul 2013 23:22:49 -0000 Message-ID: <20130718232249.1154.6441@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Thejas Nair" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/12748/ X-Sender: "Thejas Nair" References: <20130718222735.1153.50522@reviews.apache.org> In-Reply-To: <20130718222735.1153.50522@reviews.apache.org> Reply-To: "Thejas Nair" --===============5536286401666950126== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12748/ ----------------------------------------------------------- (Updated July 18, 2013, 11:22 p.m.) Review request for hive. Bugs: HIVE-4883 https://issues.apache.org/jira/browse/HIVE-4883 Repository: hive-git Description ------- TestHadoop20SAuthBridge tests testSaslWithHiveMetaStore and testMetastoreProxyUser sometimes fail. I have seen this more often on mac and windows, but this can happen on linux as well. The problem is that metastore is started in a different thread and these unit tests actually rely on the metastore having initialized DelegationTokenSecretManager in HadoopThriftAuthBridge20S as part of the metastore startup (HiveMetaStore.startMetaStore ) Diffs ----- shims/src/common-secure/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 172e031 Diff: https://reviews.apache.org/r/12748/diff/ Testing ------- Thanks, Thejas Nair --===============5536286401666950126==--