hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <>
Subject [jira] [Commented] (HIVE-4960) lastAlias in CommonJoinOperator is not used
Date Wed, 31 Jul 2013 01:30:48 GMT


Hive QA commented on HIVE-4960:

{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 2748 tests executed
*Failed tests:*

Test results:
Console output:

Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests failed with: TestsFailedException: 1 tests failed

This message is automatically generated.
> lastAlias in CommonJoinOperator is not used
> -------------------------------------------
>                 Key: HIVE-4960
>                 URL:
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Yin Huai
>            Assignee: Yin Huai
>            Priority: Minor
>         Attachments: HIVE-4960.D11895.1.patch
> In CommonJoinOperator, there is object called lastAlias. The initial value of this object
is 'null'. After tracing the usage of this object, I found that there is no place to change
the value of this object. Also, it is only used in processOp in JoinOperator and MapJoinOperator
> {code}
> if ((lastAlias == null) || (!lastAlias.equals(alias))) {
>   nextSz = joinEmitInterval;
> }
> {\code}
> Since lastAlias will always be null, we will assign joinEmitInterval to nextSz every
time we get a row. Later in processOp, we have 
> {code}
> nextSz = getNextSize(nextSz);
> {\code}
> Because we reset the value of nextSz to joinEmitInterval every time we get a row, seems
that getNextSize will not be used as expected.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message