hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-4874) Identical methods PTFDeserializer.addOIPropertiestoSerDePropsMap(), PTFTranslator.addOIPropertiestoSerDePropsMap()
Date Thu, 18 Jul 2013 15:18:49 GMT

    [ https://issues.apache.org/jira/browse/HIVE-4874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712406#comment-13712406
] 

Brock Noland commented on HIVE-4874:
------------------------------------

Looks like a simple enough patch!  Is there a review board item for this?
                
> Identical methods PTFDeserializer.addOIPropertiestoSerDePropsMap(), PTFTranslator.addOIPropertiestoSerDePropsMap()
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-4874
>                 URL: https://issues.apache.org/jira/browse/HIVE-4874
>             Project: Hive
>          Issue Type: Improvement
>          Components: PTF-Windowing
>            Reporter: Jason Dere
>            Assignee: Edward Capriolo
>            Priority: Minor
>             Fix For: 0.12.0
>
>         Attachments: HIVE-4874.patch.txt
>
>
> The following static methods look completely identical:
>   PTFDeserializer.addOIPropertiestoSerDePropsMap()
>   PTFTranslator.addOIPropertiestoSerDePropsMap()
> They can probably be refactored to a common methods that both classes use.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message