hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheng Hao (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-4864) Code Comments seems confused between GenericUDFCase & GenericUDFWhen
Date Tue, 23 Jul 2013 07:16:49 GMT

     [ https://issues.apache.org/jira/browse/HIVE-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Cheng Hao updated HIVE-4864:
----------------------------

    Attachment: 1.patch

Please check the attachment.
                
> Code Comments seems confused between GenericUDFCase & GenericUDFWhen
> --------------------------------------------------------------------
>
>                 Key: HIVE-4864
>                 URL: https://issues.apache.org/jira/browse/HIVE-4864
>             Project: Hive
>          Issue Type: Task
>            Reporter: Cheng Hao
>            Priority: Trivial
>         Attachments: 1.patch
>
>
> Code Comment in GenericUDFCase:
> /**
> * GenericUDF Class for SQL construct
> * "CASE WHEN a THEN b WHEN c THEN d [ELSE f] END".
> * 
> * NOTES: 1. a and c should be boolean, or an exception will be thrown. 2. b, d
> * and f should have the same TypeInfo, or an exception will be thrown.
> */
> And the code comment in GenericUDFWhen:
> /**
> * GenericUDF Class for SQL construct "CASE a WHEN b THEN c [ELSE f] END".
> * 
> * NOTES: 1. a and b should have the same TypeInfo, or an exception will be
>  thrown. 2. c and f should have the same TypeInfo, or an exception will be
> * thrown.
> */
> From the code itself, seems the comments should be exchanged. We'd better amend that
to avoid confusing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message