hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward Capriolo (JIRA)" <>
Subject [jira] [Commented] (HIVE-4732) Speed up AvroSerde by checking hashcodes instead of equality
Date Mon, 01 Jul 2013 21:57:20 GMT


Edward Capriolo commented on HIVE-4732:

This change definitely assumes that we won't be unlucky and have a hashcode collision.

^ is a dangerous assumption I would not want to +1.

&& wouldn't allow short circuiting if hashCodes were equal, only if they're unequal.

Ah good point. I just meant to say 'use short circuiting and a compound if clause' (it could
use ! | || && or & or whatever your need. The point was you can optimize the code
without making it logically incorrect. 
> Speed up AvroSerde by checking hashcodes instead of equality
> ------------------------------------------------------------
>                 Key: HIVE-4732
>                 URL:
>             Project: Hive
>          Issue Type: Improvement
>          Components: Serializers/Deserializers
>            Reporter: Mark Wagner
>            Assignee: Mark Wagner
>         Attachments: HIVE-4732.1.patch
> The AvroSerde spends a significant amount of time checking schema equality. Changing
to compare hashcodes (which can be computed once then reused) will improve performance.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message