hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-4226) Cleanup non-threadsafe code in Hive
Date Tue, 16 Jul 2013 13:22:55 GMT

     [ https://issues.apache.org/jira/browse/HIVE-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Phabricator updated HIVE-4226:
------------------------------

    Attachment: HIVE-4226.D11703.1.patch

tarball requested code review of "HIVE-4226 [jira] Cleanup non-threadsafe code in Hive".

Reviewers: JIRA

HIVE-4226. Fixing some non-threadsafe code in hive

There is some code in Hive that is not threadsafe. These usually bubble up as problems in
Hive Server. This JIRA tracks fixing (hopefully, all) of these issues.

Some context: we've implemented a multi-tenant (multiple dbs), multi-threaded hive server
at Qubole (QHS) which is running in production for a couple of months now. As part of this
effort, we've fixed a number of instances of non-threadsafe code. I'm looking to contribute
this back to the community.

Note that there is no new functionality here - just some better hygiene. If there are any
stress tests that have revealed hive server bugs in the past, it will be great if they can
be added to the jira.

Also, this is my first attempt at contributing to Apache, so please forgive any mistakes.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D11703

AFFECTED FILES
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
  ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
  ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
  ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java
  ql/src/java/org/apache/hadoop/hive/ql/index/AggregateIndexHandler.java
  ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java
  ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveInputFormat.java
  ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java
  ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveRecordReader.java
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyProcFactory.java
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndex.java
  ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorFactory.java
  ql/src/java/org/apache/hadoop/hive/ql/stats/StatsFactory.java

MANAGE HERALD RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/27753/

To: JIRA, tarball

                
> Cleanup non-threadsafe code in Hive
> -----------------------------------
>
>                 Key: HIVE-4226
>                 URL: https://issues.apache.org/jira/browse/HIVE-4226
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Sivaramakrishnan Narayanan
>            Assignee: Sivaramakrishnan Narayanan
>         Attachments: HIVE-4226.1.patch.txt, HIVE-4226.2.patch.txt, HIVE-4226.D11703.1.patch
>
>
> There is some code in Hive that is not threadsafe. These usually bubble up as problems
in Hive Server. This JIRA tracks fixing (hopefully, all) of these issues.
> Some context: we've implemented a multi-tenant (multiple dbs), multi-threaded hive server
at Qubole (QHS) which is running in production for a couple of months now. As part of this
effort, we've fixed a number of instances of non-threadsafe code. I'm looking to contribute
this back to the community.
> Note that there is no new functionality here - just some better hygiene. If there are
any stress tests that have revealed hive server bugs in the past, it will be great if they
can be added to the jira.
> Also, this is my first attempt at contributing to Apache, so please forgive any mistakes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message