hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@gmail.com>
Subject Re: Review Request 12926: Implemented end-to-end support for SUBSTR() with changes to VectorizationContext class
Date Thu, 25 Jul 2013 17:56:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12926/#review23857
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
<https://reviews.apache.org/r/12926/#comment47686>

    I think it should be Concat??


- Timothy Chen


On July 24, 2013, 10:34 p.m., Eric Hanson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12926/
> -----------------------------------------------------------
> 
> (Updated July 24, 2013, 10:34 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-4512
>     https://issues.apache.org/jira/browse/HIVE-4512
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Implemented end-to-end support for SUBSTR() with changes to VectorizationContext class
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 9c90230

>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatColScalar.java
29ef244 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatScalarCol.java
14205ee 
> 
> Diff: https://reviews.apache.org/r/12926/diff/
> 
> 
> Testing
> -------
> 
> Verified all these queries run vectorized:
> 
> explain 
> select l_shipmode, concat(l_shipmode, "<<<")
> from lineitem_orc 
> where l_orderkey = 1;
> 
> select l_shipmode, concat('>>>', l_shipmode)
> from lineitem_orc 
> where l_orderkey = 1;
> 
> select l_shipmode, concat('>>>', l_shipmode)
> from lineitem_orc 
> where l_orderkey = 1
> and lower(l_shipmode) = 'mail';
> 
> 
> select l_shipmode, concat(l_shipmode, l_shipmode)
> from lineitem_orc 
> where l_orderkey = 1;
> 
> select l_shipmode, concat(lower(l_shipmode), upper(lower(l_shipmode)))
> from lineitem_orc 
> where l_orderkey = 1;
> 
> 
> Thanks,
> 
> Eric Hanson
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message