hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yin Huai" <h...@cse.ohio-state.edu>
Subject Re: Review Request 12795: [HIVE-4827] Merge a Map-only job to its following MapReduce job with multiple inputs
Date Tue, 23 Jul 2013 19:38:25 GMT


> On July 23, 2013, 2:22 a.m., Gunther Hagleitner wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java, line 4
> > <https://reviews.apache.org/r/12795/diff/2/?file=324291#file324291line4>
> >
> >     Don't we still need the copyright?

We do not need the header. This copyright line was from the trunk.


> On July 23, 2013, 2:22 a.m., Gunther Hagleitner wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java,
line 420
> > <https://reviews.apache.org/r/12795/diff/2/?file=324292#file324292line420>
> >
> >     Why is it better to throw exception here than simply return?

If we only expect a TableScanOperator at here, I think it may be better to throw an exception
instead of swallowing the error. 


> On July 23, 2013, 2:22 a.m., Gunther Hagleitner wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java,
line 446
> > <https://reviews.apache.org/r/12795/diff/2/?file=324292#file324292line446>
> >
> >     Why is this? Should work regardless, no?

This part is from trunk. I will take a look and see why we need it


- Yin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12795/#review23671
-----------------------------------------------------------


On July 22, 2013, 4:19 a.m., Yin Huai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12795/
> -----------------------------------------------------------
> 
> (Updated July 22, 2013, 4:19 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-4827
>     https://issues.apache.org/jira/browse/HIVE-4827
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-4827
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java 66b84ff 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java
f98878c 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/MapredWork.java 7cbb1ff 
>   ql/src/test/queries/clientpositive/correlationoptimizer7.q 9b18972 
>   ql/src/test/queries/clientpositive/multiMapJoin2.q PRE-CREATION 
>   ql/src/test/results/clientpositive/auto_join33.q.out 8fc0e84 
>   ql/src/test/results/clientpositive/correlationoptimizer1.q.out db3bd78 
>   ql/src/test/results/clientpositive/correlationoptimizer3.q.out cebddff 
>   ql/src/test/results/clientpositive/correlationoptimizer4.q.out 285a54f 
>   ql/src/test/results/clientpositive/correlationoptimizer6.q.out c40a786 
>   ql/src/test/results/clientpositive/correlationoptimizer7.q.out ea54431 
>   ql/src/test/results/clientpositive/multiMapJoin1.q.out 3b3eb3f 
>   ql/src/test/results/clientpositive/multiMapJoin2.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12795/diff/
> 
> 
> Testing
> -------
> 
> Running tests.
> 
> 
> Thanks,
> 
> Yin Huai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message