hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 12826: HIVE-4913: Put deterministic ordering in the top-K ngrams output of UDF context_ngrams()
Date Mon, 22 Jul 2013 22:51:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12826/
-----------------------------------------------------------

(Updated July 22, 2013, 10:51 p.m.)


Review request for hive.


Bugs: HIVE-4913
    https://issues.apache.org/jira/browse/HIVE-4913


Repository: hive-git


Description
-------

Patch add tie breaker when two entries have the same ngram.


Diffs
-----

  metastore/src/model/package.jdo a84d2bf 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/NGramEstimator.java 0ef8fca 
  ql/src/test/results/clientpositive/udaf_context_ngrams.q.out de2d395 

Diff: https://reviews.apache.org/r/12826/diff/


Testing
-------

Test udaf_context_ngrams.q fails when running on JDK7. With the patch, the test passes.


Thanks,

Xuefu Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message