hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Swarnim Kulkarni" <kulkarni.swar...@gmail.com>
Subject Re: Review Request 9276: Add support for pulling HBase columns with prefixes
Date Mon, 22 Jul 2013 01:20:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9276/
-----------------------------------------------------------

(Updated July 22, 2013, 1:20 a.m.)


Review request for hive.


Changes
-------

Updated diff with proposed changes.


Bugs: HIVE-3725
    https://issues.apache.org/jira/browse/HIVE-3725


Repository: hive-git


Description
-------

Added support for pulling hbase columns just by providing prefixes and a wildcard. So a query
now could look something like this:

CREATE EXTERNAL TABLE hive_hbase_test
ROW FORMAT SERDE 'org.apache.hadoop.hive.hbase.HBaseSerDe' 
STORED BY 'org.apache.hadoop.hive.hbase.HBaseStorageHandler' 
WITH SERDEPROPERTIES ("hbase.columns.mapping" = ":key,fam1:col*") 
TBLPROPERTIES ("hbase.table.name" = "TEST_HBASE_TABLE");

This would pull in all columns under column family "fam1" which start with "col". This gives
a little more flexibility over pull all columns format.


Diffs (updated)
-----

  hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java 65c81bf 
  hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java b550f45 
  hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java 01938a7

  hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseCellMap.java a8ba9d9 
  hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseRow.java 10a9207 
  hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestHBaseSerDe.java e821282 

Diff: https://reviews.apache.org/r/9276/diff/


Testing
-------

Added unit tests to demonstrate the new functionality. Also made sure that all existing unit
tests passed.


Thanks,

Swarnim Kulkarni


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message