hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin" <ser...@hortonworks.com>
Subject Re: Review Request 12750: HIVE-3632: Upgrade datanucleus to support JDK7
Date Fri, 19 Jul 2013 21:23:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12750/#review23553
-----------------------------------------------------------



ivy/libraries.properties
<https://reviews.apache.org/r/12750/#comment47453>

    is connection pool removed intentionally? HIVE-4807 changed pooling enabled by default
to solve some problem, I had trouble starting metastore with that setting without this jar.
Could just be me but worth checking



metastore/src/model/package.jdo
<https://reviews.apache.org/r/12750/#comment47454>

    this (and other stuff above and below) will require schema upgrade script as far as I
see


- Sergey Shelukhin


On July 18, 2013, 11:27 p.m., Xuefu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12750/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 11:27 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-3632
>     https://issues.apache.org/jira/browse/HIVE-3632
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> 1. Upgrade DataNucleus to 3.2 stable version.
> 2. Fix a few issues that arose.
> 
> While the fix is motivated for JDK7 support, the patch is completely applicable for running
with JDK6.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 11c3121 
>   conf/hive-default.xml.template 603b475 
>   ivy/libraries.properties 0e1b992 
>   metastore/build.xml 0e94611 
>   metastore/ivy.xml 356e19d 
>   metastore/src/model/package.jdo a84d2bf 
>   ql/ivy.xml bfb3116 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9883659 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java cbda70b 
>   ql/src/test/results/clientpositive/alter_rename_partition_authorization.q.out 4262b7c

>   ql/src/test/results/clientpositive/authorization_2.q.out c934a2a 
>   ql/src/test/results/clientpositive/authorization_6.q.out b8483ca 
> 
> Diff: https://reviews.apache.org/r/12750/diff/
> 
> 
> Testing
> -------
> 
> 1. Ran all unit tests with 0.10.0 as the base, and all pased.
> 2. Ran all unit tests with trunk, and there was a test failure but seemingly unrelated.
Conducting further testing. (Second run was successful!)
> 3. Ran some basic end2end tests. Issues are fixed as they arise. The effort will continue.
> 
> 
> Thanks,
> 
> Xuefu Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message