hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yin Huai" <h...@cse.ohio-state.edu>
Subject Re: Review Request 12767: [HIVE-4877] In ExecReducer, remove tag from the row which will be passed to the first Operator at the Reduce-side
Date Fri, 19 Jul 2013 19:00:10 GMT


> On July 19, 2013, 6:25 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/MuxOperator.java, line 299
> > <https://reviews.apache.org/r/12767/diff/1/?file=323661#file323661line299>
> >
> >     Should we also add following in comment?
> >     .. and directly call process on children in process() method.

It sounds better.


- Yin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12767/#review23531
-----------------------------------------------------------


On July 19, 2013, 5 p.m., Yin Huai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12767/
> -----------------------------------------------------------
> 
> (Updated July 19, 2013, 5 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-4877
>     https://issues.apache.org/jira/browse/HIVE-4877
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-4877
> 
> 
> Diffs
> -----
> 
>   data/files/kv1kv2.cogroup.txt 6d36e22 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DemuxOperator.java 9898495 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MuxOperator.java d4be3d9 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java ee76917 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java cbda70b 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java d12a53c 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 6a74ae4 
> 
> Diff: https://reviews.apache.org/r/12767/diff/
> 
> 
> Testing
> -------
> 
> Tests	Failures	Errors	Success rate	Time
> 2688	2	        0	99.93%	        43249.945
> 
> Two failures are hbase_stats_empty_partition.q and ppd_key_ranges.q in TestHBaseCliDriver.
> 
> I manually tested these two in my mac and tests passed. 
> 
> 
> Thanks,
> 
> Yin Huai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message