Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B2087107B5 for ; Fri, 14 Jun 2013 01:13:20 +0000 (UTC) Received: (qmail 75873 invoked by uid 500); 14 Jun 2013 01:13:20 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 75832 invoked by uid 500); 14 Jun 2013 01:13:20 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 75823 invoked by uid 500); 14 Jun 2013 01:13:20 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 75820 invoked by uid 99); 14 Jun 2013 01:13:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Jun 2013 01:13:20 +0000 Date: Fri, 14 Jun 2013 01:13:20 +0000 (UTC) From: "Phabricator (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-4733) HiveLockObjectData is not compared properly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-4733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HIVE-4733: ------------------------------ Attachment: HIVE-4733.D11277.1.patch navis requested code review of "HIVE-4733 [jira] HiveLockObjectData is not compared properly". Reviewers: JIRA HIVE-4733 HiveLockObjectData is not compared properly ret = ret && (clientIp == null) ? target.getClientIp() == null : clientIp.equals(target.getClientIp()); seemed intended to be ret = ret && (clientIp == null ? target.getClientIp() == null : clientIp.equals(target.getClientIp())); TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D11277 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java MANAGE HERALD RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/26811/ To: JIRA, navis > HiveLockObjectData is not compared properly > ------------------------------------------- > > Key: HIVE-4733 > URL: https://issues.apache.org/jira/browse/HIVE-4733 > Project: Hive > Issue Type: Bug > Components: Locking > Reporter: Navis > Assignee: Navis > Priority: Trivial > Fix For: 0.12.0 > > Attachments: HIVE-4733.D11277.1.patch > > > {noformat} > ret = ret && (clientIp == null) ? target.getClientIp() == null : > clientIp.equals(target.getClientIp()); > {noformat} > seemed intended to be > {noformat} > ret = ret && (clientIp == null ? target.getClientIp() == null : > clientIp.equals(target.getClientIp())); > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira