Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B60F0CDEF for ; Tue, 11 Jun 2013 17:02:58 +0000 (UTC) Received: (qmail 41554 invoked by uid 500); 11 Jun 2013 17:02:58 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 41089 invoked by uid 500); 11 Jun 2013 17:02:52 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 41049 invoked by uid 99); 11 Jun 2013 17:02:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jun 2013 17:02:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 30F411CA71D; Tue, 11 Jun 2013 17:02:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4812808135899563510==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-4712: Fix TestCliDriver.truncate_* on 0.23 From: "Ashutosh Chauhan" To: "Ashutosh Chauhan" Cc: "Brock Noland" , "hive" Date: Tue, 11 Jun 2013 17:02:43 -0000 Message-ID: <20130611170243.3558.36368@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ashutosh Chauhan" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/11801/ X-Sender: "Ashutosh Chauhan" References: <20130611071815.3558.18317@reviews.apache.org> In-Reply-To: <20130611071815.3558.18317@reviews.apache.org> Reply-To: "Ashutosh Chauhan" --===============4812808135899563510== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11801/#review21708 ----------------------------------------------------------- Ship it! +1 - Ashutosh Chauhan On June 11, 2013, 7:18 a.m., Brock Noland wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11801/ > ----------------------------------------------------------- > = > (Updated June 11, 2013, 7:18 a.m.) > = > = > Review request for hive and Ashutosh Chauhan. > = > = > Description > ------- > = > Queries just needed and order by to be deterministic. > = > = > This addresses bug HIVE-4712. > https://issues.apache.org/jira/browse/HIVE-4712 > = > = > Diffs > ----- > = > ql/src/test/queries/clientpositive/truncate_column.q f172bae = > ql/src/test/queries/clientpositive/truncate_column_merge.q 20ef643 = > ql/src/test/results/clientpositive/truncate_column.q.out f8af6d0 = > ql/src/test/results/clientpositive/truncate_column_merge.q.out 64a917b = > = > Diff: https://reviews.apache.org/r/11801/diff/ > = > = > Testing > ------- > = > Passes with both 0.20S and 0.23. > = > = > Thanks, > = > Brock Noland > = > --===============4812808135899563510==--