Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9FD4F10F2A for ; Tue, 4 Jun 2013 00:54:43 +0000 (UTC) Received: (qmail 6377 invoked by uid 500); 4 Jun 2013 00:54:43 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 6318 invoked by uid 500); 4 Jun 2013 00:54:43 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 6302 invoked by uid 99); 4 Jun 2013 00:54:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Jun 2013 00:54:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A1D7D1CC6CB; Tue, 4 Jun 2013 00:54:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0123123010439233152==" MIME-Version: 1.0 Subject: Re: Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0) From: "Shreepadma Venugopalan" To: "fangkun cao" , "Ashutosh Chauhan" , "Carl Steinbach" Cc: "hive" , "Shreepadma Venugopalan" , "Zhuoluo Yang" Date: Tue, 04 Jun 2013 00:54:36 -0000 Message-ID: <20130604005436.22886.17745@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Shreepadma Venugopalan" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/11172/ X-Sender: "Shreepadma Venugopalan" References: <20130603044604.22853.41409@reviews.apache.org> In-Reply-To: <20130603044604.22853.41409@reviews.apache.org> Reply-To: "Shreepadma Venugopalan" --===============0123123010439233152== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11172/#review21391 ----------------------------------------------------------- Ship it! Ship It! - Shreepadma Venugopalan On June 3, 2013, 4:46 a.m., Zhuoluo Yang wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11172/ > ----------------------------------------------------------- > = > (Updated June 3, 2013, 4:46 a.m.) > = > = > Review request for hive, Carl Steinbach, Carl Steinbach, Ashutosh Chauhan= , and fangkun cao. > = > = > Description > ------- > = > An initialization error. > Make double and long initialize correctly. > Would you review that and assign the issue to me? > = > = > This addresses bug HIVE-4561. > https://issues.apache.org/jira/browse/HIVE-4561 > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoo= p/hive/ql/udf/generic/GenericUDAFComputeStats.java 1488823 = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpo= sitive/compute_stats_long.q.out 1488823 = > = > Diff: https://reviews.apache.org/r/11172/diff/ > = > = > Testing > ------- > = > ant test -Dtestcase=3DTestCliDriver -Dqfile=3Dcompute_stats_long.q > ant test -Dtestcase=3DTestCliDriver -Dqfile=3Dcompute_stats_double.q > = > done. > = > = > Thanks, > = > Zhuoluo Yang > = > --===============0123123010439233152==--