Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 54872C7E1 for ; Mon, 3 Jun 2013 04:46:14 +0000 (UTC) Received: (qmail 39462 invoked by uid 500); 3 Jun 2013 04:46:13 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 39346 invoked by uid 500); 3 Jun 2013 04:46:12 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 39331 invoked by uid 99); 3 Jun 2013 04:46:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Jun 2013 04:46:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 561B31CC529; Mon, 3 Jun 2013 04:46:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5383784576341346080==" MIME-Version: 1.0 Subject: Re: Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0) From: "Zhuoluo Yang" To: "fangkun cao" , "Ashutosh Chauhan" , "Carl Steinbach" Cc: "Zhuoluo Yang" , "hive" Date: Mon, 03 Jun 2013 04:46:04 -0000 Message-ID: <20130603044604.22853.41409@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Zhuoluo Yang" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/11172/ X-Sender: "Zhuoluo Yang" References: <20130603030436.22886.52377@reviews.apache.org> In-Reply-To: <20130603030436.22886.52377@reviews.apache.org> Reply-To: "Zhuoluo Yang" --===============5383784576341346080== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11172/ ----------------------------------------------------------- (Updated June 3, 2013, 4:46 a.m.) Review request for hive, Carl Steinbach, Carl Steinbach, Ashutosh Chauhan, = and fangkun cao. Description ------- An initialization error. Make double and long initialize correctly. Would you review that and assign the issue to me? This addresses bug HIVE-4561. https://issues.apache.org/jira/browse/HIVE-4561 Diffs ----- http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/= hive/ql/udf/generic/GenericUDAFComputeStats.java 1488823 = http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientposi= tive/compute_stats_long.q.out 1488823 = Diff: https://reviews.apache.org/r/11172/diff/ Testing ------- ant test -Dtestcase=3DTestCliDriver -Dqfile=3Dcompute_stats_long.q ant test -Dtestcase=3DTestCliDriver -Dqfile=3Dcompute_stats_double.q done. Thanks, Zhuoluo Yang --===============5383784576341346080==--