hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-4798) NPE when we call isSame from an instance of ExprNodeConstantDesc with null value
Date Sun, 30 Jun 2013 06:09:20 GMT

    [ https://issues.apache.org/jira/browse/HIVE-4798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696282#comment-13696282
] 

Ashutosh Chauhan commented on HIVE-4798:
----------------------------------------

I agree. Can you provide a patch for it?
                
> NPE when we call isSame from an instance of ExprNodeConstantDesc with null value
> --------------------------------------------------------------------------------
>
>                 Key: HIVE-4798
>                 URL: https://issues.apache.org/jira/browse/HIVE-4798
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Yin Huai
>            Assignee: Yin Huai
>            Priority: Minor
>
> Take a look at the code
> {code}
>   @Override
>   public boolean isSame(Object o) {
>     if (!(o instanceof ExprNodeConstantDesc)) {
>       return false;
>     }
>     ExprNodeConstantDesc dest = (ExprNodeConstantDesc) o;
>     if (!typeInfo.equals(dest.getTypeInfo())) {
>       return false;
>     }
>     if (!value.equals(dest.getValue())) {
>       return false;
>     }
>     return true;
>   }
> {\code}
> value is an Object.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message