hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <>
Subject [jira] [Commented] (HIVE-4719) EmbeddedLockManager should be shared to all clients
Date Wed, 26 Jun 2013 02:35:20 GMT


Phabricator commented on HIVE-4719:

navis has commented on the revision "HIVE-4719 [jira] EmbeddedLockManager should be shared
to all clients".

  I think codes related to locks and hooks could be separated to another classes. But it would
be better to concentrate on this specific issue.

  ql/src/java/org/apache/hadoop/hive/ql/ Yes, I considered throwing exception.
But in the original implementation, if client failed to instantiate a lock manager, hive had
just logs it and continued. I cannot sure which one is better.
  ql/src/java/org/apache/hadoop/hive/ql/ Same with above.
  ql/src/java/org/apache/hadoop/hive/ql/lockmgr/ I'm in a little
old way of thinking that implementation of interface is not override. But I'll add that.


To: JIRA, navis
Cc: brock

> EmbeddedLockManager should be shared to all clients
> ---------------------------------------------------
>                 Key: HIVE-4719
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-4719.D11229.1.patch, HIVE-4719.D11229.2.patch
> Currently, EmbeddedLockManager is created per Driver instance, so locking has no meaning.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message