hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shreepadma Venugopalan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-4549) JDBC compliance change TABLE_SCHEMA to TABLE_SCHEM
Date Fri, 07 Jun 2013 17:54:20 GMT

    [ https://issues.apache.org/jira/browse/HIVE-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13678217#comment-13678217
] 

Shreepadma Venugopalan commented on HIVE-4549:
----------------------------------------------

+1 (non-committer). LGTM.
                
> JDBC compliance change TABLE_SCHEMA to TABLE_SCHEM
> --------------------------------------------------
>
>                 Key: HIVE-4549
>                 URL: https://issues.apache.org/jira/browse/HIVE-4549
>             Project: Hive
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions: 0.10.0
>         Environment: Hive 0.10
>            Reporter: Johndee Burks
>            Assignee: Prasad Mujumdar
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 0.12.0
>
>         Attachments: HIVE-4549-1.patch
>
>
> The ResultSet returned by HiveDatabaseMetadata.getTables has the metadata columns TABLE_CAT,
TABLE_SCHEMA, TABLE_NAME, TABLE_TYPE, REMARKS. The second column name is not compliant with
the JDBC standard (http://docs.oracle.com/javase/6/docs/api/java/sql/DatabaseMetaData.html#getSchemas()):
the column name should be TABLE_SCHEM instead of TABLE_SCHEMA.
> Suggested fix in Hive (org.apache.hive.service.cli.operation.GetTablesOperation.java)
change from
> private static final TableSchema RESULT_SET_SCHEMA = new TableSchema() 
> .addStringColumn("TABLE_CAT", "Catalog name. NULL if not applicable.") 
> .addStringColumn("TABLE_SCHEMA", "Schema name.") 
> .addStringColumn("TABLE_NAME", "Table name.") 
> .addStringColumn("TABLE_TYPE", "The table type, e.g. \"TABLE\", \"VIEW\", etc.") 
> .addStringColumn("REMARKS", "Comments about the table.");
> to
> private static final TableSchema RESULT_SET_SCHEMA = new TableSchema() 
> .addStringColumn("TABLE_CAT", "Catalog name. NULL if not applicable.") 
> .addStringColumn("TABLE_SCHEM", "Schema name.") 
> .addStringColumn("TABLE_NAME", "Table name.") 
> .addStringColumn("TABLE_TYPE", "The table type, e.g. \"TABLE\", \"VIEW\", etc.") 
> .addStringColumn("REMARKS", "Comments about the table.");

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message