hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland" <br...@cloudera.com>
Subject Re: Review Request: HIVE-4670. Authentication module should pass the instance part of the Kerberos principle
Date Fri, 07 Jun 2013 17:08:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11705/#review21583
-----------------------------------------------------------


Hi,

LGLT! There are two minor nit's I noticed while looking at the patch.


shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java
<https://reviews.apache.org/r/11705/#comment44634>

    nit: trailing whitespace
    



shims/src/common-secure/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java
<https://reviews.apache.org/r/11705/#comment44633>

    nit: commented out import


- Brock Noland


On June 7, 2013, 1:33 a.m., Shreepadma Venugopalan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11705/
> -----------------------------------------------------------
> 
> (Updated June 7, 2013, 1:33 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Navis Ryu.
> 
> 
> Description
> -------
> 
> When Kerberos authentication is enabled for HiveServer2, the thrift SASL layer passes
instance@realm from the principal. This patch makes the fix necessary to pass the "short"
kerberos name to HS2 instead.
> 
> 
> This addresses bug HIVE-4670.
>     https://issues.apache.org/jira/browse/HIVE-4670
> 
> 
> Diffs
> -----
> 
>   shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java c9baa7f 
>   shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java e4a632d 
>   shims/src/0.23/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java 1975385 
>   shims/src/common-secure/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java
777226f 
>   shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java b0f5077 
> 
> Diff: https://reviews.apache.org/r/11705/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shreepadma Venugopalan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message