hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shreepadma Venugopalan" <shreepa...@cloudera.com>
Subject Re: Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)
Date Wed, 05 Jun 2013 00:00:37 GMT


> On June 4, 2013, 11:09 p.m., Shreepadma Venugopalan wrote:
> > Ship It!

I think its OK to have Long.MAX_VALUE/Long.MIN_VALUE as the min/max value if there are no
rows in the table. 


- Shreepadma


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11172/#review21438
-----------------------------------------------------------


On June 4, 2013, 1:41 p.m., Zhuoluo Yang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11172/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 1:41 p.m.)
> 
> 
> Review request for hive, Carl Steinbach, Carl Steinbach, Ashutosh Chauhan, Shreepadma
Venugopalan, and fangkun cao.
> 
> 
> Description
> -------
> 
> An initialization error.
> Make double and long initialize correctly.
> Would you review that and assign the issue to me?
> 
> 
> This addresses bug HIVE-4561.
>     https://issues.apache.org/jira/browse/HIVE-4561
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java
1489292 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/compute_stats_empty_table.q.out
1489292 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/compute_stats_long.q.out
1489292 
> 
> Diff: https://reviews.apache.org/r/11172/diff/
> 
> 
> Testing
> -------
> 
> ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_long.q
> ant test -Dtestcase=TestCliDriver -Dqfile=compute_stats_double.q
> 
> done.
> 
> 
> Thanks,
> 
> Zhuoluo Yang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message