Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 95498D4F5 for ; Mon, 27 May 2013 02:32:22 +0000 (UTC) Received: (qmail 99018 invoked by uid 500); 27 May 2013 02:32:21 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 98955 invoked by uid 500); 27 May 2013 02:32:21 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 98942 invoked by uid 500); 27 May 2013 02:32:20 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 98924 invoked by uid 99); 27 May 2013 02:32:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 May 2013 02:32:20 +0000 Date: Mon, 27 May 2013 02:32:20 +0000 (UTC) From: "Phabricator (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-4572) ColumnPruner cannot preserve RS key columns corresponding to un-selected join keys in columnExprMap MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HIVE-4572: ------------------------------ Attachment: HIVE-4572.D10941.1.patch yhuai requested code review of "HIVE-4572 [jira] ColumnPruner cannot preserve RS key columns corresponding to un-selected join keys in columnExprMap". Reviewers: JIRA Merge branch 'trunk' of https://github.com/apache/hive into HIVE-4572 For a RS of a join operator, if the join key corresponding to this RS does not appear in the SELECT clause, ColumnPruner will drop the entry of this column in colExprMap. Example: SELECT x.key FROM src1 x JOIN src y ON (x.key = y.key); Before CP, colExprMap of RS corresponding to x: {VALUE._col3=Column[INPUT__FILE__NAME], VALUE._col2=Column[BLOCK__OFFSET__INSIDE__FILE], VALUE._col1=Column[value], VALUE._col0=Column[key]}; colExprMap of RS corresponding to y: {VALUE._col3=Column[INPUT__FILE__NAME], VALUE._col2=Column[BLOCK__OFFSET__INSIDE__FILE], VALUE._col1=Column[value], VALUE._col0=Column[key]}. After CP, colExprMap of RS corresponding to x: {VALUE._col0=Column[key]}; colExprMap of RS corresponding to y: {}. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D10941 AFFECTED FILES jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java ql/src/test/results/compiler/plan/join1.q.xml ql/src/test/results/compiler/plan/join3.q.xml MANAGE HERALD RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/26163/ To: JIRA, yhuai > ColumnPruner cannot preserve RS key columns corresponding to un-selected join keys in columnExprMap > --------------------------------------------------------------------------------------------------- > > Key: HIVE-4572 > URL: https://issues.apache.org/jira/browse/HIVE-4572 > Project: Hive > Issue Type: Bug > Affects Versions: 0.12.0 > Reporter: Yin Huai > Assignee: Yin Huai > Attachments: HIVE-4572.1.patch.txt, HIVE-4572.2.patch.txt, HIVE-4572.D10941.1.patch, HIVE-4572.replay.patch > > > For a RS of a join operator, if the join key corresponding to this RS does not appear in the SELECT clause, ColumnPruner will drop the entry of this column in colExprMap. > Example: > {code} > SELECT x.key FROM src1 x JOIN src y ON (x.key = y.key); > {\code} > Before CP, > {code} > colExprMap of RS corresponding to x: {VALUE._col3=Column[INPUT__FILE__NAME], VALUE._col2=Column[BLOCK__OFFSET__INSIDE__FILE], VALUE._col1=Column[value], VALUE._col0=Column[key]}; > colExprMap of RS corresponding to y: {VALUE._col3=Column[INPUT__FILE__NAME], VALUE._col2=Column[BLOCK__OFFSET__INSIDE__FILE], VALUE._col1=Column[value], VALUE._col0=Column[key]}. > {\code} > After CP, > {code} > colExprMap of RS corresponding to x: {VALUE._col0=Column[key]}; > colExprMap of RS corresponding to y: {}. > {\code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira