Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 16499F8B1 for ; Tue, 28 May 2013 16:31:16 +0000 (UTC) Received: (qmail 85260 invoked by uid 500); 28 May 2013 16:31:15 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 85183 invoked by uid 500); 28 May 2013 16:31:15 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 85167 invoked by uid 99); 28 May 2013 16:31:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 May 2013 16:31:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 141F71CB8F4; Tue, 28 May 2013 16:31:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6273740466342981497==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-4548 Speed up vectorized LIKE filter for special cases abc%, %abc and %abc% From: "Eric Hanson" To: "Eric Hanson" , "Teddy Choi" , "hive" Date: Tue, 28 May 2013 16:31:09 -0000 Message-ID: <20130528163109.1390.1415@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Eric Hanson" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/11222/ X-Sender: "Eric Hanson" References: <20130528011046.1348.74514@reviews.apache.org> In-Reply-To: <20130528011046.1348.74514@reviews.apache.org> Reply-To: "Eric Hanson" --===============6273740466342981497== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11222/#review21099 ----------------------------------------------------------- Ship it! Ship It! - Eric Hanson On May 28, 2013, 1:10 a.m., Teddy Choi wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11222/ > ----------------------------------------------------------- > = > (Updated May 28, 2013, 1:10 a.m.) > = > = > Review request for hive. > = > = > Description > ------- > = > I edited FilterStringColLikeStringScala.java as Eric Hanson wrote. > = > For none-complex patterns, it calls a static method that doesn't call oth= ers and uses its given byte arrays only. For complex patterns, it reuses a = ByteBuffer and a CharBuffer for decoding UTF-8 to avoid object construction= s. > = > There is 30%~170% performance improvement for all cases. Its benchmark re= sult is on https://issues.apache.org/jira/browse/HIVE-4548#comment-13660750. > = > It still can be more efficient by using a template-driven approach. I'll = apply it soon. > = > = > This addresses bug HIVE-4548. > https://issues.apache.org/jira/browse/HIVE-4548 > = > = > Diffs > ----- > = > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterStr= ingColLikeStringScalar.java 24ba861 = > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVecto= rStringExpressions.java 6e26412 = > = > Diff: https://reviews.apache.org/r/11222/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Teddy Choi > = > --===============6273740466342981497==--