Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B1EFFDC85 for ; Sat, 25 May 2013 11:32:28 +0000 (UTC) Received: (qmail 59068 invoked by uid 500); 25 May 2013 11:32:28 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 58993 invoked by uid 500); 25 May 2013 11:32:27 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 58732 invoked by uid 99); 25 May 2013 11:32:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 25 May 2013 11:32:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4E03B1CB52F; Sat, 25 May 2013 11:32:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7535208559888155668==" MIME-Version: 1.0 Subject: Review Request: Support COUNT(*) in vectorized aggregates From: "Remus Rusanu" To: "Remus Rusanu" , "hive" Date: Sat, 25 May 2013 11:32:21 -0000 Message-ID: <20130525113221.28982.92615@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Remus Rusanu" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/11426/ X-Sender: "Remus Rusanu" Reply-To: "Remus Rusanu" --===============7535208559888155668== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11426/ ----------------------------------------------------------- Review request for hive. Description ------- Vectorized COUNT(*) for all types. = This addresses bug HIVE-4452. https://issues.apache.org/jira/browse/HIVE-4452 Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.ja= va 1ef4955 = ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/= VectorUDAFCountStar.java PRE-CREATION = ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperat= or.java b3b5cd2 = Diff: https://reviews.apache.org/r/11426/diff/ Testing ------- New UT added, manually tested in hive-cli Thanks, Remus Rusanu --===============7535208559888155668==--