Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 479821193C for ; Mon, 13 May 2013 09:06:19 +0000 (UTC) Received: (qmail 83065 invoked by uid 500); 13 May 2013 09:06:18 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 83014 invoked by uid 500); 13 May 2013 09:06:18 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 82997 invoked by uid 99); 13 May 2013 09:06:18 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 May 2013 09:06:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8E2E11C99E0; Mon, 13 May 2013 09:06:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4452483719671387812==" MIME-Version: 1.0 Subject: Review Request: HIVE-4547: A complex create view statement fails with new Antlr 3.4 From: "Prasad Mujumdar" To: "Ashutosh Chauhan" Cc: "Prasad Mujumdar" , "hive" Date: Mon, 13 May 2013 09:06:13 -0000 Message-ID: <20130513090613.23050.17561@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Prasad Mujumdar" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/11084/ X-Sender: "Prasad Mujumdar" Reply-To: "Prasad Mujumdar" --===============4452483719671387812== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11084/ ----------------------------------------------------------- Review request for hive and Ashutosh Chauhan. Description ------- The parser has a translation map where its possible to replace all the text= with the appropriate escaped version in case of a view creation. This hold= s all individual translations and where they apply in the view definition. The newer antlr version seems to be more restrictive and throws assertion i= f there's an overlaps in these escape positions. The original patch for ant= lr upgrade added a check to take care of some of the simpler overlap cases = found by unit tests. There are few more scenarios like the one in the custo= mer case which are not covered. The patch includes Traverse the list of translation in a loop and look for = all the possible overlaps. This addresses bug HIVE-4547. https://issues.apache.org/jira/browse/HIVE-4547 Diffs ----- data/files/v1.txt PRE-CREATION = data/files/v2.txt PRE-CREATION = ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java ec2c08= 8 = ql/src/test/queries/clientpositive/view_cast.q PRE-CREATION = ql/src/test/results/clientpositive/view_cast.q.out PRE-CREATION = Diff: https://reviews.apache.org/r/11084/diff/ Testing ------- Ran full test suite. = Added new test. Thanks, Prasad Mujumdar --===============4452483719671387812==--